[CHE-173] Refactor Auth Middleware #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the CHE-167 Back End Error Handling Refactor story, this PR aims to:
protect
auth middleware to make use of custom error classesvalidate-session
auth route and authController to use of theprotect
middlewareuser
field to express's Request interface to eliminate the need to define aCustomRequest
typeCustomRequest
interface and any usage of itprotect
middleware in router filesJira Task
JIRA TICKET
Testing Instructions
npm run docker-remove-all
npm run docker-build-check
to ensure linting and tests passnpm run docker-dev
Checklist
All Team Members
npm run docker-build-check
in my local environment to check that this PR passes all linting checks and unit tests.